riscv: gate counter CSRs on mcounteren at every priv version - #2392
Open
carlosqwqqwq wants to merge 1 commit into
Open
riscv: gate counter CSRs on mcounteren at every priv version#2392carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
carlosqwqqwq
force-pushed
the
fix/riscv-counter-csr-mcounteren
branch
from
August 29, 2026 07:23
3e600c7 to
c827380
Compare
Author
|
Thank you very much for taking the time to review this PR. We have rebased it onto dev and added a focused unit test for the counter-access behavior. Could you please let us know what further code, test, or PR changes you would recommend? We will gladly adjust the patch to match the project guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2387
Change
Remove the version-based early-success branch from qemu/target/riscv/csr.c:ctr() so the existing mcounteren and scounteren checks apply to every supported privileged-spec version. M-mode access remains unchanged.
Validation
Public reproducer:
https://github.com/carlosqwqqwq/unicorn-riscv-repros/tree/main/u009
Verify that M-mode counter access is unaffected, S/U-mode accesses are gated by
mcounteren/scounteren, and existing counter and CSR tests remain unchanged.